Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starttime parameter confusion for station service #140

Closed
nbalfour opened this issue Jan 22, 2018 · 8 comments
Closed

Starttime parameter confusion for station service #140

nbalfour opened this issue Jan 22, 2018 · 8 comments
Assignees

Comments

@nbalfour
Copy link
Contributor

The FDSN specification is a bit confusing when it comes to how it deals with starttime for the station service. See this thread http://www.fdsn.org/message-center/thread/176/

The main point is the last sentence in the paragraph under Time Parameter Interpretation.
"The selection shall include any metadata epochs intersecting with the specified time range."
This implies that as long as a station's status is open at the start of the time period it should be returned.

Our current implementation of starttime for the station service only returns stations that open after or at starttime.

Can we please change the the starttime for the station service to include all stations open at starttime.

@calum-chamberlain
Copy link

👍 Just ran into this issue using what worked in #129 before, and does not work now.

@junghao
Copy link
Contributor

junghao commented Jan 23, 2018

@nbalfour
For "intersecting with the specified time range" it brings more confusion:

Consider the timeline:
screen shot 2018-01-24 at 11 44 17

The horizontal line represents the metadata active period. And query parameters are arrows below.
If there's only 1 query parameter "startTime", then:
For current implementation:
Case 1 - station included.
Case 2 - station excluded
Case 3 - station excluded

New implementation:
Case 1 - station is excluded.
Case 2 - station is included.
Case 3 - station is excluded ("not intersecting with the specified time range") -> Is this what we want?

@calum-chamberlain
Copy link

As a user, I would expect:

  1. Include
  2. Include
  3. Exclude
    Which was (I think) what we were getting before, and I think what @megies was getting at in the link @nbalfour posted.

@junghao
Copy link
Contributor

junghao commented Jan 23, 2018

From @calum-chamberlain 's comment I think what we're expecting becomes (from the algorithm level):

Include a station if its end time is after the "startTime" query parameter.

Is that right?

@ozym
Copy link

ozym commented Jan 23, 2018

That sounds right.

@nbalfour
Copy link
Contributor Author

@junghao yes that is right

@junghao
Copy link
Contributor

junghao commented Jan 24, 2018

@nbalfour @calum-chamberlain
However for

  1. Include
  2. Include
  3. Exclude

Then startTime is a duplicate for endBefore.

junghao added a commit to junghao/fdsn that referenced this issue Jan 24, 2018
gclitheroe pushed a commit that referenced this issue Jan 24, 2018
Fix query start/end time as discussed in #140.
@nbalfour
Copy link
Contributor Author

Check the service and it's working as excepted. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants