Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling sqs cancel. #111

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Better handling sqs cancel. #111

merged 1 commit into from
Sep 1, 2022

Conversation

junghao
Copy link
Contributor

@junghao junghao commented Sep 1, 2022

Proposed Changes

This makes it easier to check sqs context canceled.

Refer https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md#error-handling

Changes proposed in this pull request:

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@junghao junghao requested a review from bpeng September 1, 2022 01:18
@quiffman quiffman merged commit afa08f2 into main Sep 1, 2022
@junghao junghao requested a review from a team September 1, 2022 02:30
@junghao junghao deleted the sqs-context branch September 1, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants