Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared UI - Header and Footer #115

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Shared UI - Header and Footer #115

merged 5 commits into from
Oct 16, 2022

Conversation

CallumNZ
Copy link
Contributor

Reference: https://github.com/GeoNet/tickets/issues/11449 , https://github.com/GeoNet/tickets/issues/11435

Changes proposed in this pull request:

  • Upgrade go version to 1.16
  • Add UI package, includes functions that return HTML for GeoNet header, footer, and basic header.
  • Add hidden Mac file to .gitignore
  • Update CSP so that search form in header works in any GeoNet domain.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and handy to use

@sue-h-gns sue-h-gns merged commit 0e8fb70 into main Oct 16, 2022
@sue-h-gns sue-h-gns deleted the sharedUI branch October 16, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants