Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying lint. #56

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Applying lint. #56

merged 1 commit into from
Apr 2, 2019

Conversation

junghao
Copy link
Contributor

@junghao junghao commented Apr 1, 2019

Proposed Changes

Resolves #.

Changes proposed in this pull request:

  • Applying golangci-lint

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@@ -408,13 +408,13 @@ func (m *map3857) nePolySVG(zoom int, layer int) (string, error) {
switch m.crossesCentral {
case true:
// things to the left of 180.
db.QueryRow(svgPolyQuery,
_ = db.QueryRow(svgPolyQuery,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the ignoring of this error, refer to the comment in the beginning of func.

@danieldooley danieldooley merged commit 1f0ace3 into GeoNet:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants