-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't rename db instance #15
Comments
@Spy-Shifty the database instance is taking the hostname from the service name declared in the docker-compose file. This is by design for docker-compose networking. We actually don't need to have it dynamically defined because it is used only for internal communication among containers. I'm going to close this. |
Francesco, the snippet of code he linked to has "db" hardcoded. Are you
sure there is a parameter to change it?
…On Wed, Jul 10, 2019 at 9:31 AM Francesco Bartoli ***@***.***> wrote:
Closed #15 <#15>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AAANNV2QPWJPLVPQHTH4C4DP6XXCTA5CNFSM4HANCJ72YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSNR2OZY#event-2472781671>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANNV4Q3JOCQQ3YZVSKOMDP6XXCTANCNFSM4HANCJ7Q>
.
|
Hi @ingenieroariel no there isn’t but that change doesn’t make sense to me. Why should we make it a variable? What’s the benefit? |
I just checked the actual code, since it is all in tasks.py and that is
tied to the current docker implementation I guess it is okay and end users
can just override it if they need to.
My main gripe was if it was harcoded in GeoNode itself (the django project).
-a
…On Wed, Jul 10, 2019 at 10:39 AM Francesco Bartoli ***@***.***> wrote:
Hi @ingenieroariel <https://github.com/ingenieroariel> no there isn’t but
that change doesn’t make sense to me. Why should we make it a variable?
What’s the benefit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AAANNV7CPW5XOM2D2GN7J73P6X7CJA5CNFSM4HANCJ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZT3ZYI#issuecomment-510115041>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANNV5LQQSDC4KVFWGPXVLP6X7CJANCNFSM4HANCJ7Q>
.
|
When using docker-compose the database instance has to be "db" because of:
Please change the code to some thing like this:
Where the environment variables are like:
The text was updated successfully, but these errors were encountered: