-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #11316] external pyCSW Service breaks upload of Documents and Datasets #11319
[Fixes #11316] external pyCSW Service breaks upload of Documents and Datasets #11319
Conversation
…ts and Datasets
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #11319 +/- ##
=======================================
Coverage 60.61% 60.61%
=======================================
Files 867 867
Lines 52597 52597
Branches 6724 6724
=======================================
Hits 31882 31882
Misses 19180 19180
Partials 1535 1535 |
…upload_of_documents_and_datasets
…upload_of_documents_and_datasets
…upload_of_documents_and_datasets
…upload_of_documents_and_datasets
…upload_of_documents_and_datasets
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Django Secret Key | 09c8a0f | .env.sample | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
This PR is related to #11316 . In my working of trying to bring an external pyCSW service to the geonode-k8s (zalf-rdm/geonode-k8s#34). I'm using the geonode.settings variables:
CATALOGUE_ENGINE=geonode.catalogue.backends.pycsw_http
andCATALOGUE_URL=http://my-external-pycsw:8000
I stumbled on uploading of documents and datasets wasn't working anymore like described in issue #11316.
So I tracked this down and found some datatype expectations made in geonode/catalgue/backends/generic.py are not working properly. Further I found out that for some reason the contextprocessor for the
CATALOG_METADATA_TEMPLATE
isn't working inside of thetransaction_delete.xml
,transaction_update.xml
andtransaction_insert.xml
which lead to a template rendering issue when using an external pyCSW service. So I added this variable through the template context.This are overall very minor changes.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.