Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#27 pycsw single microservice #34

Closed
wants to merge 32 commits into from

Conversation

mwallschlaeger
Copy link
Contributor

Closes #27

📑 Description

ref #27

added pycsw microservice inspired by pycsw helm chart (https://github.com/geopython/pycsw/tree/master/docker/helm) with adoption to the style of this helm chart.

Implementation:

ℹ Additional Information

@mwallschlaeger mwallschlaeger added enhancement New feature or request feature new required feature labels Jul 31, 2023
@mwallschlaeger mwallschlaeger self-assigned this Jul 31, 2023
@mwallschlaeger
Copy link
Contributor Author

waiting for GeoNode/geonode#11319 . meanwhile you can use the following geonode image including the bugfix promoted inside the PR.

  image:
    # -- used geonode image
    name: mwall2bitflow/geonode
    # -- tag of used geonode image
    tag: '4.1.x-pycsw-hotfix'

@mwallschlaeger
Copy link
Contributor Author

GeoNode/geonode#11319 got merged, so no reason to hold this back anymore

@mwallschlaeger mwallschlaeger changed the title Issue#27 py csw single microservice Issue#27 pycsw single microservice Aug 23, 2023
deployment/geonode/templates/_helpers.tpl Show resolved Hide resolved
name: {{ .Release.Name }}-pycsw-cfg
namespace: {{ .Release.Namespace }}
data:
pycsw.cfg: |+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we better include that configuration as is in the values.yml and embed the config via {{- include "pycsw.config" . | nindent 4 }}?

docs/pycsw.md Outdated Show resolved Hide resolved

The pycsw configuration (pycsw.cfg) and mappings are defined in the values file: `[ .Values.pycsw.config , .Values.pycsw.mappings ]`

The csw endpoint is default set to the one used within Geonode: `/catalogue/csw`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a link reference here, e.g. https://docs.pycsw.org/en/2.6.1/configuration.html

@@ -30,6 +30,9 @@ geonode:
email_verification: "False"
authentication_method: username_email

pycsw:
enabled: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really the default?

Copy link
Contributor

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have to resolve #64 first, but at least should have a look at the way how the config is embedded in the configMap

@mwallschlaeger mwallschlaeger deleted the issue#27_pyCSW_single_microservice branch September 6, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature new required feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyCSW single microservice
2 participants