Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(src): readability improvements #257

Merged
merged 3 commits into from Aug 15, 2022
Merged

refactor(src): readability improvements #257

merged 3 commits into from Aug 15, 2022

Conversation

ryanrussell
Copy link
Contributor

Lots of small readability fixes focused on the src/.py path.

If any changes are needed, please let me know.

Best,
Ryan

@ryanrussell
doc: whether readability fixes
4ec7940 
Signed-off-by: Ryan Russell <git@ryanrussell.org>
@ryanrussell
doc: signature readability fix
f2224f1 
Signed-off-by: Ryan Russell <git@ryanrussell.org>
@ryanrussell
refactor: readability improvements in docstrings and comments
5562b85 
Signed-off-by: Ryan Russell <git@ryanrussell.org>
@LSchueler LSchueler self-assigned this Aug 15, 2022
LSchueler
LSchueler approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all those spelling mistakes and typos! I've put "install a spell checker in my editor" on my todo list :-D

@LSchueler LSchueler merged commit 661bbe6 into GeoStat-Framework:main Aug 15, 2022
@ryanrussell
Copy link
Contributor Author

ryanrussell commented Aug 15, 2022 •
edited

Thanks for fixing all those spelling mistakes and typos! I've put "install a spell checker in my editor" on my todo list :-D

Thank you for GSTools!

I bet your english is better than my german :)

I can recommend cspell, let me know if you have any questions. Happy to help.

@ryanrussell ryanrussell deleted the src-readability branch August 15, 2022 18:21
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler approved these changes

Assignees

@LSchueler LSchueler

Labels
Documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanrussell @LSchueler @MuellerSeb