Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace filter by a for loop in getMinMax to prevent the call stack to fill up. #113

Closed
wants to merge 1 commit into from

Conversation

levaphenyl
Copy link

When uploading a time series that is too large, the upload fails with error RangeError: Maximum call stack size exceeded.
This is due to the use of filter(...).map(...) in the getMinMax function, as it fills the call stack with small function calls.
Possibly related to #109

@zekeshearer
Copy link
Contributor

@levaphenyl, could you provide an example dataset that is large enough to fail without this fix? Thanks, Zeke

@daterdots
Copy link
Member

Here's a test file with 1M rows
filesdummy-input-length-1e+06.csv.zip

@levaphenyl
Copy link
Author

Closing in favor of #117, whose solution is more elegant.

@levaphenyl levaphenyl closed this Sep 29, 2022
@levaphenyl levaphenyl deleted the fix_rangeerror branch September 29, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants