fix(Topology): check the number of block CMVs wrt the number of compo… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BotellaA
reviewed
May 24, 2023
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
…solutions/OpenGeode-Inspector into fix/brepblocktopofreeline
|
You need to update your branch with the latest master/next |
BotellaA
approved these changes
May 25, 2023
Done! |
you also need to merge the master in your branch to have the last workflows |
MelchiorSchuh
approved these changes
May 25, 2023
src/geode/inspector/topology/private/brep_blocks_topology_impl.cpp
Outdated
Show resolved
Hide resolved
….cpp Co-authored-by: Melchior Schuh-Senlis <melchior.schuh-senlis@geode-solutions.com>
|
🎉 This PR is included in version 3.0.6-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nents