Feat refactor api #73

francoisbonneau · 2023-10-30T10:57:30Z

No description provided.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 479. Check the log or trigger a new build to see more.

bindings/python/src/inspector/adjacency/solid_adjacency.h

bindings/python/src/inspector/colocation/edgedcurve_colocation.h

MelchiorSchuh

A few comments, change the StrCat calls like I explained on Slack, and its good for me

bindings/python/src/inspector/colocation/edgedcurve_colocation.h

include/geode/inspector/information.h

MelchiorSchuh · 2023-10-31T09:37:18Z

include/geode/inspector/topology/brep_lines_topology.h

+                "single line is invalid."
+            };
+        ProblemInspectionResult< index_t >
+            unique_vertices_linked_to_a_line_but_not_linked_to_a_corner{


Suggested change

unique_vertices_linked_to_a_line_but_not_linked_to_a_corner{

unique_vertices_linked_to_several_lines_but_not_linked_to_a_corner{

include/geode/inspector/topology/brep_lines_topology.h

include/geode/inspector/topology/brep_surfaces_topology.h

include/geode/inspector/topology/section_lines_topology.h

src/geode/inspector/criterion/colocation/unique_vertices_colocation.cpp

include/geode/inspector/information.h

include/geode/inspector/topology/brep_blocks_topology.h

include/geode/inspector/topology/brep_topology.h

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 446. Check the log or trigger a new build to see more.

github-actions · 2023-11-03T11:13:06Z

bindings/python/src/inspector/colocation/edgedcurve_colocation.h

@@ -37,7 +37,7 @@ namespace geode
        using EdgedCurveColocation = EdgedCurveColocation< dimension >;

        const auto name =
-            "EdgedCurveColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "EdgedCurveColocation", dimension, "D" );
        pybind11::class_< EdgedCurveColocation >( module, name.c_str() )
            .def( pybind11::init< const EdgedCurve& >() )
            .def( pybind11::init< const EdgedCurve&, bool >() )


warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

.def( pybind11::init< const EdgedCurve&, bool >() ) ^

github-actions · 2023-11-03T11:13:06Z

bindings/python/src/inspector/colocation/edgedcurve_colocation.h

@@ -37,7 +37,7 @@
        using EdgedCurveColocation = EdgedCurveColocation< dimension >;

        const auto name =
-            "EdgedCurveColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "EdgedCurveColocation", dimension, "D" );
        pybind11::class_< EdgedCurveColocation >( module, name.c_str() )
            .def( pybind11::init< const EdgedCurve& >() )
            .def( pybind11::init< const EdgedCurve&, bool >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const EdgedCurve&, bool >() ) ^

github-actions · 2023-11-03T11:13:06Z

bindings/python/src/inspector/colocation/pointset_colocation.h

@@ -34,7 +34,7 @@ namespace geode
        using PointSet = PointSet< dimension >;
        using PointSetColocation = PointSetColocation< dimension >;
        const auto name =
-            "PointSetColocation" + std::to_string( dimension ) + "D";
+            "PointSetColocation" + absl::StrCat( dimension ) + "D";


warning: no header providing "absl::StrCat" is directly included [misc-include-cleaner]

bindings/python/src/inspector/colocation/pointset_colocation.h:22:

- #include <string> + #include <absl/strings/str_cat.h> + #include <string>

github-actions · 2023-11-03T11:13:07Z

bindings/python/src/inspector/colocation/pointset_colocation.h

@@ -34,7 +34,7 @@
        using PointSet = PointSet< dimension >;
        using PointSetColocation = PointSetColocation< dimension >;
        const auto name =
-            "PointSetColocation" + std::to_string( dimension ) + "D";
+            "PointSetColocation" + absl::StrCat( dimension ) + "D";
        pybind11::class_< PointSetColocation >( module, name.c_str() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

pybind11::class_< PointSetColocation >( module, name.c_str() ) ^

github-actions · 2023-11-03T11:13:07Z

bindings/python/src/inspector/colocation/pointset_colocation.h

@@ -34,7 +34,7 @@
        using PointSet = PointSet< dimension >;
        using PointSetColocation = PointSetColocation< dimension >;
        const auto name =
-            "PointSetColocation" + std::to_string( dimension ) + "D";
+            "PointSetColocation" + absl::StrCat( dimension ) + "D";
        pybind11::class_< PointSetColocation >( module, name.c_str() )


warning: unexpected type name 'PointSetColocation': expected expression [clang-diagnostic-error]

pybind11::class_< PointSetColocation >( module, name.c_str() ) ^

github-actions · 2023-11-03T11:13:08Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )


warning: unexpected type name 'SurfaceMeshColocation': expected expression [clang-diagnostic-error]

pybind11::class_< SurfaceMeshColocation >( module, name.c_str() ) ^

github-actions · 2023-11-03T11:13:08Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh& >() ) ^

github-actions · 2023-11-03T11:13:08Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh& >() ) ^

github-actions · 2023-11-03T11:13:08Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions · 2023-11-03T11:13:08Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 421. Check the log or trigger a new build to see more.

github-actions · 2023-11-03T15:39:56Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@ namespace geode
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions · 2023-11-03T15:39:56Z

bindings/python/src/inspector/colocation/surface_colocation.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
        const auto name =
-            "SurfaceMeshColocation" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshColocation", dimension, "D" );
        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions · 2023-11-03T15:39:57Z

bindings/python/src/inspector/degeneration/edgedcurve_degeneration.h

@@ -34,7 +34,7 @@ namespace geode
        using EdgedCurve = EdgedCurve< dimension >;
        using EdgedCurveDegeneration = EdgedCurveDegeneration< dimension >;
        const auto name =
-            "EdgedCurveDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "EdgedCurveDegeneration", dimension, "D" );
        pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() ) ^

github-actions · 2023-11-03T15:39:57Z

bindings/python/src/inspector/degeneration/edgedcurve_degeneration.h

@@ -34,7 +34,7 @@
        using EdgedCurve = EdgedCurve< dimension >;
        using EdgedCurveDegeneration = EdgedCurveDegeneration< dimension >;
        const auto name =
-            "EdgedCurveDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "EdgedCurveDegeneration", dimension, "D" );
        pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )


warning: unexpected type name 'EdgedCurveDegeneration': expected expression [clang-diagnostic-error]

pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() ) ^

github-actions · 2023-11-03T15:39:57Z

bindings/python/src/inspector/degeneration/edgedcurve_degeneration.h

@@ -34,7 +34,7 @@
        using EdgedCurve = EdgedCurve< dimension >;
        using EdgedCurveDegeneration = EdgedCurveDegeneration< dimension >;
        const auto name =
-            "EdgedCurveDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "EdgedCurveDegeneration", dimension, "D" );
        pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )
            .def( pybind11::init< const EdgedCurve& >() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

.def( pybind11::init< const EdgedCurve& >() ) ^

github-actions · 2023-11-03T15:39:58Z

bindings/python/src/inspector/degeneration/surface_degeneration.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
        const auto name =
-            "SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshDegeneration", dimension, +"D" );
        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh& >() ) ^

github-actions · 2023-11-03T15:39:59Z

bindings/python/src/inspector/degeneration/surface_degeneration.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
        const auto name =
-            "SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshDegeneration", dimension, +"D" );
        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh& >() ) ^

github-actions · 2023-11-03T15:39:59Z

bindings/python/src/inspector/degeneration/surface_degeneration.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
        const auto name =
-            "SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshDegeneration", dimension, +"D" );
        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions · 2023-11-03T15:39:59Z

bindings/python/src/inspector/degeneration/surface_degeneration.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
        const auto name =
-            "SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshDegeneration", dimension, +"D" );
        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: expected expression [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

github-actions · 2023-11-03T15:39:59Z

bindings/python/src/inspector/degeneration/surface_degeneration.h

@@ -34,7 +34,7 @@
        using SurfaceMesh = SurfaceMesh< dimension >;
        using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
        const auto name =
-            "SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
+            absl::StrCat( "SurfaceMeshDegeneration", dimension, +"D" );
        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
            .def( pybind11::init< const SurfaceMesh& >() )
            .def( pybind11::init< const SurfaceMesh&, bool >() )


warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

.def( pybind11::init< const SurfaceMesh&, bool >() ) ^

BotellaA · 2024-02-14T18:26:43Z

🎉 This PR is included in version 5.0.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

BotellaA · 2024-02-16T07:28:37Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

francoisbonneau and others added 14 commits October 6, 2023 12:42

refactoring corners

0a93ab5

Apply prepare changes

389552a

minor changes

2ad8000

topology inspector refactoring

54454dc

Apply prepare changes

aa6dac9

new propopsition

5e87f4f

Apply prepare changes

2281ae7

brep_inspector

43b3b17

refactoring a bit more

fc9bd9c

refactor names

728f773

Apply prepare changes

e305e37

fin brep

d21a26a

End topological inspector

16a6423

Apply prepare changes

74baa06

github-actions bot reviewed Oct 30, 2023

View reviewed changes

francoisbonneau requested review from BotellaA and MelchiorSchuh October 31, 2023 08:27

MelchiorSchuh reviewed Oct 31, 2023

View reviewed changes

BotellaA approved these changes Oct 31, 2023

View reviewed changes

francoisbonneau and others added 2 commits November 3, 2023 12:02

account for all comments related to PR73

017a9d4

Apply prepare changes

e1e6c93

github-actions bot reviewed Nov 3, 2023

View reviewed changes

francoisbonneau and others added 2 commits November 3, 2023 16:23

minor change

053bae4

Apply prepare changes

803e52a

github-actions bot reviewed Nov 3, 2023

View reviewed changes

francoisbonneau merged commit 6766a42 into refactor_all_inspector_api Nov 3, 2023
7 of 18 checks passed

francoisbonneau deleted the feat_refactor_api branch November 3, 2023 17:11

BotellaA added the released on @next label Feb 14, 2024

BotellaA added the released label Feb 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat refactor api #73

Feat refactor api #73

francoisbonneau commented Oct 30, 2023

github-actions bot left a comment

MelchiorSchuh left a comment

MelchiorSchuh Oct 31, 2023

github-actions bot left a comment

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot left a comment

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

github-actions bot Nov 3, 2023

BotellaA commented Feb 14, 2024

BotellaA commented Feb 16, 2024

	unique_vertices_linked_to_a_line_but_not_linked_to_a_corner{
	unique_vertices_linked_to_several_lines_but_not_linked_to_a_corner{

Feat refactor api #73

Feat refactor api #73

Conversation

francoisbonneau commented Oct 30, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

MelchiorSchuh left a comment

Choose a reason for hiding this comment

MelchiorSchuh Oct 31, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

github-actions bot Nov 3, 2023

Choose a reason for hiding this comment

BotellaA commented Feb 14, 2024

BotellaA commented Feb 16, 2024