Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat refactor api #73

Merged
merged 18 commits into from
Nov 3, 2023
Merged

Feat refactor api #73

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0a93ab5
refactoring corners
francoisbonneau Oct 6, 2023
389552a
Apply prepare changes
francoisbonneau Oct 6, 2023
2ad8000
minor changes
francoisbonneau Oct 6, 2023
54454dc
topology inspector refactoring
francoisbonneau Oct 16, 2023
aa6dac9
Apply prepare changes
francoisbonneau Oct 16, 2023
5e87f4f
new propopsition
francoisbonneau Oct 17, 2023
2281ae7
Apply prepare changes
francoisbonneau Oct 17, 2023
43b3b17
brep_inspector
francoisbonneau Oct 18, 2023
fc9bd9c
refactoring a bit more
MelchiorSchuh Oct 23, 2023
728f773
refactor names
francoisbonneau Oct 24, 2023
e305e37
Apply prepare changes
francoisbonneau Oct 24, 2023
d21a26a
fin brep
francoisbonneau Oct 27, 2023
16a6423
End topological inspector
francoisbonneau Oct 27, 2023
74baa06
Apply prepare changes
francoisbonneau Oct 27, 2023
017a9d4
account for all comments related to PR73
francoisbonneau Nov 3, 2023
e1e6c93
Apply prepare changes
francoisbonneau Nov 3, 2023
053bae4
minor change
francoisbonneau Nov 3, 2023
803e52a
Apply prepare changes
francoisbonneau Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,12 @@ CheckOptions:
- key: readability-identifier-naming.MemberConstantCase
value: CamelCase
- key: readability-identifier-naming.StaticConstantCase
value: CamelCase
value: lower_case
- key: readability-function-cognitive-complexity.Threshold
value: 10
- key: readability-function-size.ParameterThreshold
value: 4
- key: misc-include-cleaner.IgnoreHeaders
value: '
cstddef
.*_export\.h;
geode/.*/common\.h;
geode/basic/types\.h;
geode/basic/assert\.h;
'
value: utility;cstddef;geode/.*_export\.h;geode/.*/common\.h;geode/basic/types\.h;geode/basic/assert\.h;


8 changes: 4 additions & 4 deletions bindings/python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
#
# pip-compile --pre bindings/python/requirements.in
#
opengeode-core==14.*,>=14.9.1rc3
opengeode-core==14.*,>=14.9.1
# via
# -r bindings/python/requirements.in
# opengeode-geosciences
# opengeode-geosciencesio
# opengeode-io
opengeode-geosciences==7.*,>=7.2.1rc1
opengeode-geosciences==7.*,>=7.2.1
# via
# -r bindings/python/requirements.in
# opengeode-geosciencesio
opengeode-geosciencesio==4.*,>=4.5.0
opengeode-geosciencesio==4.*,>=4.5.1
# via -r bindings/python/requirements.in
opengeode-io==6.*,>=6.2.0
opengeode-io==6.*,>=6.2.1
# via -r bindings/python/requirements.in
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/adjacency/solid_adjacency.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshAdjacency = SolidMeshAdjacency< dimension >;
const auto name =
"SolidMeshAdjacency" + std::to_string( dimension ) + "D";
"SolidMeshAdjacency" + absl::StrCat( dimension ) + "D";
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
pybind11::class_< SolidMeshAdjacency >( module, name.c_str() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const SolidMesh& >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const SolidMesh&, bool >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/adjacency/surface_adjacency.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SurfaceMesh = SurfaceMesh< dimension >;
using SurfaceMeshAdjacency = SurfaceMeshAdjacency< dimension >;
const auto name =
"SurfaceMeshAdjacency" + std::to_string( dimension ) + "D";
"SurfaceMeshAdjacency" + absl::StrCat( dimension ) + "D";
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const SurfaceMesh& >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const SurfaceMesh&, bool >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/colocation/edgedcurve_colocation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace geode
using EdgedCurveColocation = EdgedCurveColocation< dimension >;

const auto name =
"EdgedCurveColocation" + std::to_string( dimension ) + "D";
"EdgedCurveColocation" + absl::StrCat( dimension ) + "D";
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
pybind11::class_< EdgedCurveColocation >( module, name.c_str() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const EdgedCurve& >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
.def( pybind11::init< const EdgedCurve&, bool >() )
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
francoisbonneau marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                                                          ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                                                            ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/colocation/pointset_colocation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using PointSet = PointSet< dimension >;
using PointSetColocation = PointSetColocation< dimension >;
const auto name =
"PointSetColocation" + std::to_string( dimension ) + "D";
"PointSetColocation" + absl::StrCat( dimension ) + "D";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "absl::StrCat" is directly included [misc-include-cleaner]

bindings/python/src/inspector/colocation/pointset_colocation.h:22:

- #include <string>
+ #include <absl/strings/str_cat.h>
+ #include <string>

pybind11::class_< PointSetColocation >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< PointSetColocation >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'PointSetColocation': expected expression [clang-diagnostic-error]

        pybind11::class_< PointSetColocation >( module, name.c_str() )
                          ^

.def( pybind11::init< const PointSet& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const PointSet& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const PointSet& >() )
                                  ^

.def( pybind11::init< const PointSet&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const PointSet&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const PointSet&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const PointSet&, bool >() )
                                                        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const PointSet&, bool >() )
                                                          ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/colocation/solid_colocation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshColocation = SolidMeshColocation< dimension >;
const auto name =
"SolidMeshColocation" + std::to_string( dimension ) + "D";
"SolidMeshColocation" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshColocation >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< SolidMeshColocation >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SolidMeshColocation': expected expression [clang-diagnostic-error]

        pybind11::class_< SolidMeshColocation >( module, name.c_str() )
                          ^

.def( pybind11::init< const SolidMesh& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh& >() )
                                  ^

.def( pybind11::init< const SolidMesh&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                                         ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                                           ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/colocation/surface_colocation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SurfaceMesh = SurfaceMesh< dimension >;
using SurfaceMeshColocation = SurfaceMeshColocation< dimension >;
const auto name =
"SurfaceMeshColocation" + std::to_string( dimension ) + "D";
"SurfaceMeshColocation" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SurfaceMeshColocation': expected expression [clang-diagnostic-error]

        pybind11::class_< SurfaceMeshColocation >( module, name.c_str() )
                          ^

.def( pybind11::init< const SurfaceMesh& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                                  ^

.def( pybind11::init< const SurfaceMesh&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                                                           ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                                                             ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/degeneration/edgedcurve_degeneration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using EdgedCurve = EdgedCurve< dimension >;
using EdgedCurveDegeneration = EdgedCurveDegeneration< dimension >;
const auto name =
"EdgedCurveDegeneration" + std::to_string( dimension ) + "D";
"EdgedCurveDegeneration" + absl::StrCat( dimension ) + "D";
pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'EdgedCurveDegeneration': expected expression [clang-diagnostic-error]

        pybind11::class_< EdgedCurveDegeneration >( module, name.c_str() )
                          ^

.def( pybind11::init< const EdgedCurve& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve& >() )
                                  ^

.def( pybind11::init< const EdgedCurve&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                                                          ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const EdgedCurve&, bool >() )
                                                            ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/degeneration/solid_degeneration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshDegeneration = SolidMeshDegeneration< dimension >;
const auto name =
"SolidMeshDegeneration" + std::to_string( dimension ) + "D";
"SolidMeshDegeneration" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshDegeneration >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< SolidMeshDegeneration >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SolidMeshDegeneration': expected expression [clang-diagnostic-error]

        pybind11::class_< SolidMeshDegeneration >( module, name.c_str() )
                          ^

.def( pybind11::init< const SolidMesh& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh& >() )
                                  ^

.def( pybind11::init< const SolidMesh&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                                         ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SolidMesh&, bool >() )
                                                           ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/degeneration/surface_degeneration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SurfaceMesh = SurfaceMesh< dimension >;
using SurfaceMeshDegeneration = SurfaceMeshDegeneration< dimension >;
const auto name =
"SurfaceMeshDegeneration" + std::to_string( dimension ) + "D";
"SurfaceMeshDegeneration" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
        ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SurfaceMeshDegeneration': expected expression [clang-diagnostic-error]

        pybind11::class_< SurfaceMeshDegeneration >( module, name.c_str() )
                          ^

.def( pybind11::init< const SurfaceMesh& >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                                  ^

.def( pybind11::init< const SurfaceMesh&, bool >() )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                                  ^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected '(' for function-style cast or type construction [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh&, bool >() )
                                                           ^

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/edgedcurve_inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace geode
using EdgedCurveInspector = geode::EdgedCurveInspector< dimension >;

const auto name =
"EdgedCurveInspector" + std::to_string( dimension ) + "D";
"EdgedCurveInspector" + absl::StrCat( dimension ) + "D";
pybind11::class_< EdgedCurveInspector,
EdgedCurveColocation< dimension >,
EdgedCurveDegeneration< dimension > >( module, name.c_str() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/intersections/surface_curve_intersections.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace geode
using SurfaceCurveIntersections =
SurfaceCurveIntersections< dimension >;
const auto name =
"SurfaceCurveIntersections" + std::to_string( dimension ) + "D";
"SurfaceCurveIntersections" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceCurveIntersections >( module, name.c_str() )
.def( pybind11::init< const TriangulatedSurface&,
const EdgedCurve& >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/intersections/surface_intersections.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace geode
using TriangulatedSurfaceIntersections =
TriangulatedSurfaceIntersections< dimension >;
const auto name = "TriangulatedSurfaceIntersections"
+ std::to_string( dimension ) + "D";
+ absl::StrCat( dimension ) + "D";
pybind11::class_< TriangulatedSurfaceIntersections >(
module, name.c_str() )
.def( pybind11::init< const TriangulatedSurface& >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/manifold/solid_edge_manifold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshEdgeManifold = SolidMeshEdgeManifold< dimension >;
const auto name =
"SolidMeshEdgeManifold" + std::to_string( dimension ) + "D";
"SolidMeshEdgeManifold" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshEdgeManifold >( module, name.c_str() )
.def( pybind11::init< const SolidMesh& >() )
.def( pybind11::init< const SolidMesh&, bool >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/manifold/solid_facet_manifold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshFacetManifold = SolidMeshFacetManifold< dimension >;
const auto name =
"SolidMeshFacetManifold" + std::to_string( dimension ) + "D";
"SolidMeshFacetManifold" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshFacetManifold >( module, name.c_str() )
.def( pybind11::init< const SolidMesh& >() )
.def( pybind11::init< const SolidMesh&, bool >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/manifold/solid_vertex_manifold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SolidMesh = SolidMesh< dimension >;
using SolidMeshVertexManifold = SolidMeshVertexManifold< dimension >;
const auto name =
"SolidMeshVertexManifold" + std::to_string( dimension ) + "D";
"SolidMeshVertexManifold" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshVertexManifold >( module, name.c_str() )
.def( pybind11::init< const SolidMesh& >() )
.def( pybind11::init< const SolidMesh&, bool >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/manifold/surface_edge_manifold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace geode
using SurfaceMesh = SurfaceMesh< dimension >;
using SurfaceMeshEdgeManifold = SurfaceMeshEdgeManifold< dimension >;
const auto name =
"SurfaceMeshEdgeManifold" + std::to_string( dimension ) + "D";
"SurfaceMeshEdgeManifold" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceMeshEdgeManifold >( module, name.c_str() )
.def( pybind11::init< const SurfaceMesh& >() )
.def( pybind11::init< const SurfaceMesh&, bool >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/manifold/surface_vertex_manifold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace geode
using SurfaceMeshVertexManifold =
SurfaceMeshVertexManifold< dimension >;
const auto name =
"SurfaceMeshVertexManifold" + std::to_string( dimension ) + "D";
"SurfaceMeshVertexManifold" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceMeshVertexManifold >( module, name.c_str() )
.def( pybind11::init< const SurfaceMesh& >() )
.def( pybind11::init< const SurfaceMesh&, bool >() )
Expand Down
3 changes: 1 addition & 2 deletions bindings/python/src/inspector/pointset_inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ namespace geode
{
using PointSet = PointSet< dimension >;
using PointSetInspector = PointSetInspector< dimension >;
const auto name =
"PointSetInspector" + std::to_string( dimension ) + "D";
const auto name = "PointSetInspector" + absl::StrCat( dimension ) + "D";
pybind11::class_< PointSetInspector, PointSetColocation< dimension > >(
module, name.c_str() )
.def( pybind11::init< const PointSet& >() )
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/src/inspector/solid_inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace geode
using SolidMesh = geode::SolidMesh< dimension >;
using SolidMeshInspector = geode::SolidMeshInspector< dimension >;
const auto name =
"SolidMeshInspector" + std::to_string( dimension ) + "D";
"SolidMeshInspector" + absl::StrCat( dimension ) + "D";
pybind11::class_< SolidMeshInspector, SolidMeshAdjacency< dimension >,
SolidMeshColocation< dimension >,
SolidMeshDegeneration< dimension >,
Expand Down
4 changes: 2 additions & 2 deletions bindings/python/src/inspector/surface_inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace geode
using TriangulatedSurfaceInspector =
TriangulatedSurfaceInspector< dimension >;
const auto name =
"SurfaceMeshInspector" + std::to_string( dimension ) + "D";
"SurfaceMeshInspector" + absl::StrCat( dimension ) + "D";
pybind11::class_< SurfaceMeshInspector,
SurfaceMeshAdjacency< dimension >,
SurfaceMeshColocation< dimension >,
Expand All @@ -48,7 +48,7 @@ namespace geode
.def( pybind11::init< const SurfaceMesh&, bool >() );

const auto trgl_name =
"TriangulatedSurfaceInspector" + std::to_string( dimension ) + "D";
"TriangulatedSurfaceInspector" + absl::StrCat( dimension ) + "D";
pybind11::class_< TriangulatedSurfaceInspector, SurfaceMeshInspector,
TriangulatedSurfaceIntersections< dimension > >(
module, trgl_name.c_str() )
Expand Down
Loading
Loading