Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning reported on macs. #503

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

MFraters
Copy link
Member

@MFraters MFraters commented Jul 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #503 (894e046) into main (04161ab) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 894e046 differs from pull request most recent head 32bb6aa. Consider uploading reports for the commit 32bb6aa to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   93.44%   93.43%   -0.01%     
==========================================
  Files          91       91              
  Lines        6299     6293       -6     
==========================================
- Hits         5886     5880       -6     
  Misses        413      413              
Impacted Files Coverage Δ
source/world_builder/objects/bezier_curve.cc 100.00% <ø> (ø)
source/world_builder/utilities.cc 97.03% <ø> (-0.01%) ⬇️
source/world_builder/world.cc 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04161ab...32bb6aa. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.256 ± 0.002 (s=339) 1.257 ± 0.003 (s=380) +0.0% .. +0.1%
Slab interpolation curved simple none 1.265 ± 0.005 (s=365) 1.265 ± 0.003 (s=349) -0.0% .. +0.1%
Spherical slab interpolation simple none 1.499 ± 0.004 (s=306) 1.499 ± 0.004 (s=297) -0.1% .. +0.0%
Slab interpolation simple curved CMS 1.371 ± 0.004 (s=326) 1.370 ± 0.006 (s=333) -0.2% .. +0.0%
Spherical slab interpolation simple CMS 2.341 ± 0.004 (s=207) 2.338 ± 0.004 (s=180) -0.2% .. -0.1%
Spherical fault interpolation simple none 1.813 ± 0.006 (s=244) 1.811 ± 0.006 (s=255) -0.2% .. +0.0%
Cartesian min max surface 3.501 ± 0.029 (s=124) 3.494 ± 0.016 (s=136) -0.5% .. +0.1%
Spherical min max surface 9.163 ± 0.018 (s=46) 9.170 ± 0.019 (s=55) -0.1% .. +0.2%

@MFraters
Copy link
Member Author

MFraters commented Jul 9, 2023

fixes #502 which was reported by @tjhei

@MFraters MFraters merged commit edf9ef2 into GeodynamicWorldBuilder:main Jul 9, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant