Fix for warnings from world builder. #5230
Conversation
|
This makes sense. Are these the warnings I reported to you? |
|
When and where did you send them? These where warnings reported by @anne-glerum and @bobmyhill. I also made a pull request for the world builder in GeodynamicWorldBuilder/WorldBuilder#503. I could make a point release, I am not sure if it is worth it. |
| (void) this->limit_debug_consistency_checks; | ||
| WBAssert(!this->limit_debug_consistency_checks || this->parameters.coordinate_system->natural_coordinate_system() == cartesian |
There was a problem hiding this comment.
Does it really warn about this variable being unused? It's a member variable, how does the compiler know that the function isn't used anywhere else?
There was a problem hiding this comment.
In debug mode is isn't used anywhere. I never got this warning, but it does appear on some mac's apparently.
|
I'm ok to merge as-is, in the same way as we often apply small patches to bundled packages to avoid warnings. But I'll defer to @tjhei if he has a different opinion. |
|
Here is the issue I opened: GeodynamicWorldBuilder/WorldBuilder#502 |
Ah, sorry. I had completely missed that. Can you confirm that it is fixed now? |
|
@bobmyhill confirmed that the warnings are gone for him. |
@bobmyhill and @anne-glerum could you test if this fixes the issue?
@tjhei It would be great to take this over in the release branch