Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of the Old Files/Folders in cran_include #277

Merged

Conversation

Soumya624
Copy link
Contributor

Modified the contents of cran_include branch with the latest files/folders from the develop branch. These can be used in the submodule path of Rvolesti.

vissarion and others added 30 commits December 10, 2019 16:38
…lue_and_imports

Few fixes in C++ and python
Passing volume constants by reference
…input variables' names in round_polytope R function.
…ealing fails. Update sample_points rd file. Fix bug in c++ generator.
dymil and others added 24 commits July 18, 2022 16:47
)

* Fix rnum=0 causing integer overflow in SoB volume

rnum-1 is passed into RandomPointGenerator::apply a few lines later

* Tweak bugfix and add 1D volume test
Force rnum>=2 rather than >=1,
so that all three walk methods succeed for 1D case.
Small rnum's due to larger error or n_threads may fail in other ways
in higher dimensions, e.g., empty balls check
* update README.md and Cmakefile

* fix errors

* Cmake fix for test
Move compute_diameter functions in one place and fix R-CMD-check-ubuntu
* first commit

* draft

* draft

* update some code

* finish Point_matrix.cpp

* change name: CorreSpectra.cpp

* update

* TODO

* change TODO

* update

* update

* update

* update

* clean

* update

* correlation class

* billiard walk

* eigenvaluescorrelation.h

* update

* update

* update

* update

* update

* update

* faster billiard walk

* add missing CMake file

* start hmc

* add old sampler file

* Revert "add old sampler file"

This reverts commit 1b2f299.

* Revert "start hmc"

This reverts commit 642d4e1.

* revert commits of HMC walk

* clean unecessary code and fix minor changes

* New class CorreSpectra inherits from Spectrahedron

* add first code of ReHMC with leap frog for Gaussian sampling for testing

* relocate files:

* sample_correlation_matrices.hpp -> sampling/

* test.hpp -> test/sampling_correlation_matrices_test.cpp

* ReHMC.cpp -> random_walks/gaussian_ReHMC_correlation.hpp

* move test files to test folder and add more test

* change ReHMC code to WalkType class to suit volesti

* move content of EigenvaluesCorrelation to EigenvaluesProblems

remove temporary HCM walk

change Walk Length of test to 1

* simplify code of corre_spectra.hpp

* new correlation matrix class : CorreSpectra2 (testing: run for n=3, bug for n=10)

* fix bugs of CorreSpectra2 for BilliardWalk

* add some more tests + optimize reflection of CorreSpectra2

* fix some bugs of Spectrahedra to run BallWalk and AcceleratedBilliardWalk

* New changes:

* Change name of CorreSpectr2 -> CorreSpectra_MT

* Added and tested BallWalk for CorreSpectra_MT

* Compute diameter: remove NT(6)

* Remove commented code

* remove redundant comments

* add examples for sampling correlation matrices and remove redundant functions in tests

* added RDHR walk + fixed small changes

* remove redundant files in examples

* update CMakeLists in examples to enable MKL

* change MKL linking in examples' CMakeLists.txt

* change const specifier in several functions + readded const for Polytope arguments in functions of uniform_ball_walk.hpp

* add const specifier to is_in in spectrahedron class (required for Ball Walk)

* newline end of gitignore

* add copyright to examples

* format uniform_billiard_walk.hpp (indent, trailing spaces,...)

* change header guards of convex_bodies correlation_matrices files

* fix bugs in Spectrahedron line_intersect (wrong sign of negative distance) and change order of vector coefficients of CorreSpectra to lower triangular part (to homogenize with CorreSpectra_MT)

* homogenize check_output in tests for CorreSpectra and CorreSpectra_MT

* change names of CorreSpectra classes to CorrelationSpectrahedron

* change include path of CorrelationSpectrahedron in random walks

* format and optimize (minor) sampling/sphere.hpp

* add Copyright headers

* format style corre_matrix.hpp

* format style CorrelationSpectrahedron

* format style CorrelationSpectrahedron classes

* move direct (old) sampling functions to examples and remove tests for those functions in test file

* remove old tests from CMakeLists.txt

* add const keywords back to RDHR Walk

* fix bugs in corre_matrix

* add const keyword back to gaussian random point generator

Co-authored-by: phuoc <huu-phuoc.le@lip6.fr>
Co-authored-by: Vissarion Fisikopoulos <fisikop@gmail.com>
Fix doctest compilation error and update actions
* Add rng parameter for MC integration + fix dimension bug

* Fix parameters order

* Adjust coding style (spaces)

* Change order of parameters `dim` and `rng` in mc integration

* Pass `rng` parameter to mc integration function in tests

* Indent using spaces
Adding WSL and MKL build instructions.
@Soumya624 Soumya624 changed the title Modification of the Old Files/Folders Modification of the Old Files/Folders in cran_include Jul 8, 2023
@Soumya624 Soumya624 force-pushed the enhancement/update_cran_include branch from e626402 to 5a1cf3e Compare July 10, 2023 16:19
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vissarion vissarion merged commit 5f9d566 into GeomScale:cran_include Jul 10, 2023
@vissarion vissarion added the CRAN label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet