Position Nudging after Position Update #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfisikop
reviewed
Jun 11, 2024
include/convex_bodies/hpolytope.h
Outdated
| //Nudging correction | ||
| NT eps = -1e-7; | ||
|
|
||
| NT eps_1 = -(*b_data - A.row(i) * p.getCoefficients()); |
There was a problem hiding this comment.
This is already computed above.
include/convex_bodies/hpolytope.h
Outdated
| NT eps = -1e-7; | ||
|
|
||
| NT eps_1 = -(*b_data - A.row(i) * p.getCoefficients()); | ||
| MT A_nor = A; |
There was a problem hiding this comment.
You do not need to normalize the whole matrix A but only the violated facet.
| @@ -105,6 +105,8 @@ struct Walk | |||
| _lambda_prev = pbpair.first; | |||
| T -= _lambda_prev; | |||
| update_position(_p, _v, _lambda_prev, _omega); | |||
| if(P.is_in(_p) != -1) | |||
There was a problem hiding this comment.
No need to check if _p is in P, this is tested by nudge_in.
vfisikop
reviewed
Jun 14, 2024
| @@ -89,6 +89,9 @@ struct Walk | |||
| unsigned int n = P.dimension(); | |||
| NT T; | |||
|
|
|||
| //normalize the Polyope | |||
| P.normalize(); | |||
There was a problem hiding this comment.
The walk should not (ideally) change the Polytope!
This is a design mistake since P should be a const &.
However, changing
vgnecula
force-pushed
the
reflection_nudging
branch
3 times, most recently
from
383ed83
to
6dc3108
Compare
vfisikop
reviewed
Jun 20, 2024
include/convex_bodies/hpolytope.h
Outdated
| row_norm = A.row(i).norm(); | ||
| A.row(i) = A.row(i) / row_norm; | ||
| b(i) = b(i) / row_norm; | ||
| if(!is_normalized()){ |
There was a problem hiding this comment.
please fix style and indentation here.
TolisChal
reviewed
Jun 24, 2024
Comment on lines
242
to
250
| MT A = P.get_mat(); | ||
| VT b = P.get_vec(); | ||
|
|
||
| int m = A.rows(); | ||
| const NT* b_data = b.data(); | ||
|
|
||
| for (int i = 0; i < m; i++) { | ||
|
|
||
| NT dist = *b_data - A.row(i) * p.getCoefficients(); |
There was a problem hiding this comment.
You can do it as follows (because it is more efficient):
VT b_Ax = P.get_mat()p.getCoefficients();
NT b_Ax_data() = b_Ax.data();
for (int = 0; i < m; i++) { // then dist = *b_Ax_data;
TolisChal
approved these changes
Jun 24, 2024
vgnecula
force-pushed
the
reflection_nudging
branch
2 times, most recently
from
f6bd5a9
to
95ee8e1
Compare
TolisChal
pushed a commit
that referenced
this pull request
Jul 7, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
that referenced
this pull request
Jul 7, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
TolisChal
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Position Nudging after Position Update * Complexity improvements and Polytope Normalization * HPolytope Normalization Flag * Polytope normalization within Walk Constructor * Alias HPolytope Normalization for Nudging inside Gaussian HMC * Polytope Normalization in ComputeInner Ball Fixed * Polytope Normalization Style change * Nudge in function within Gaussian HMC, and restore Hpoly file * More efficient Nudge in Process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem related to points being rendered outside due to float arithmetic computation during the update_position() function.