Handle shortlinks in print #477
Conversation
|
Will do Concerning the URLs, it seems that c2cgeoportal doesnt support Port number in the template, I don't know about the instance name, which didnt get attached in my setup ... I believe this is an upstream issue in c2cgeoportal |
Definitely, and one that may not be easy to fix. We will have to talk to @sbrunner about that. |
|
In practice, for our deployment might not matter much, as we will use http://g-o.lu domain , with no port number ... |
|
Shorturl refactor is okay, regarding print functionality, I dont have a working print setup , so cant review this bit. @jaykayone can you help me there ? |
|
no working setup here either .. |
|
On http://devv3.geoportail.lu/main there is a print service running (tomcat), but the printproxy does not seem to work: http://devv3.geoportail.lu/main/wsgi/printproxy/status/undefined.json The page keeps sending bad requests once the print button has been pushed |
|
@jaykayone I think it'd be good to discuss that issue elsewhere as it is unrelated to the shorcurl support. I'll create a separate issue. |
|
ok |
|
For me looks okay to merge ! @elemoine |
|
Can this be merged and the print problem be adressed in a separate pull request ? |
|
Just wanted to ask again if this can be merged, as I would like to use the shorturl service for #205 |
|
I have a problem with merging this because, because of the shortlink issue, printing would not work on people's development environments. So I'd like to find a solution first. @sbrunner suggested a solution to me, but I still need to test it. Can't you just extract out the shorturl service from my branch into yours? I can rebase my branch onto master if your branch is merged into master before mine. |
|
Okay will try ! |
elemoine
force-pushed
the
elemoine_print-shorturl
branch
from
4f5c0c7
to
0c736e8
Compare
|
I've made progress with this, but I have one remaining problem: geoportailv3's |
|
@petzlux already did that in his right click PR |
Nice! |
elemoine
force-pushed
the
elemoine_print-shorturl
branch
from
c096602
to
4343d26
Compare
elemoine
force-pushed
the
elemoine_print-shorturl
branch
from
df4e4af
to
215aef2
Compare
In this way MapFish Print can make requests to the host, which is necessary to generate QR codes.
elemoine
force-pushed
the
elemoine_print-shorturl
branch
from
215aef2
to
6e71e9d
Compare
|
I am happy to merge this if @petzlux agrees to rebase his branch onto master when this is merged :-) |
|
👍 yes will rebase |
…rturl Handle shortlinks in print
This PR factors out the "interact with shorturl web service" code in a specific Angular service, and make the shorturl and the print directives rely on that service.
Unfortunately the "shorturl" web service does not work locally on my dev environment. It returns short URLs that look like this:
http://localhost/elemoine/s/PIR4(the port number has been removed, and the instanceid has been added).@petzlux, could you please review this? In the mean time, I can try to test it on our dev server.
Fixes #470.