Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either joins with has_many through association #56

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

VSidhArt
Copy link
Contributor

@VSidhArt VSidhArt commented Feb 7, 2021

Issue:

When using either_joins/2 with has_many through association, the query fails, because in where condition used final table name, not 'through' table

Solution

In method xor_field_options_for_associations if reflection.through_reflection? use 'through' reflection

@GeorgeKaraszi
Copy link
Owner

Hey sorry for radio silence, been on vacation for past couple of weeks.

Thanks for this addition and AFAIK this look pretty good 👍

@GeorgeKaraszi GeorgeKaraszi merged commit 8c9d1a3 into GeorgeKaraszi:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants