-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 7 Support #65
Conversation
df8ad2c
to
efbe649
Compare
Hey @mbell697 ! Thanks for taking a crack at Rails 7 compatibility. And yes Travis has finally bitten the bullet. If you've got the experience dealing with Github Actions, I welcome the changes to get it up and running. Always nice to see if changes break backwards compatibility 😉. |
Was there any progress on this? :) |
29904ed
to
69f924c
Compare
69f924c
to
a2254e3
Compare
I've updated this PR with the following:
I think this PR is now good to merge for Rails 7 / Ruby 3.0/3.1 support. Cheers! |
This look good! ... Thank you for your hard work on this @mbell697 ... I will plan for a new release this week. |
Hello and thank you for this library!
This PR adds support for Rails 7. I tried to minimize changes but it did require a couple tweaks to the dev environment in order to support Rails 7. For example the
.ruby-version
needed to be brought up since Rails 7 require Ruby >2.7.In terms of code - I only needed to change a single version check to get all tests to pass, I also pulled this check out to a constant for a nice little performance boost and future proofing.
I saw in another PR that there are some issues with Travis - been there :) I'm happy to open a separate PR to move this repo over to use Github Actions assuming it's setup for the repo and that is the direction you'd like to go.
Cheers!