Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift some functions from transform to convert #101

Merged
merged 1 commit into from
May 1, 2020
Merged

Shift some functions from transform to convert #101

merged 1 commit into from
May 1, 2020

Conversation

harry093
Copy link
Collaborator

@harry093 harry093 commented May 1, 2020

Shift functions grid2geo, geo2grid, llh2xyz, and xyz2llh (and associated functions) from transform to convert. Opens #100

Closes #98

@harry093 harry093 requested a review from BatchelorJ May 1, 2020 06:03
BatchelorJ
BatchelorJ approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@BatchelorJ BatchelorJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work mate, looks fine to me.

@harry093 harry093 merged commit 0debd56 into master May 1, 2020
@harry093 harry093 deleted the move-functions-from-transform-convert branch May 1, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatchelorJ BatchelorJ BatchelorJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shift llh2xyz, xyz2llh, grid2geo, and geo2grid from transform module to convert module
2 participants
@harry093 @BatchelorJ