Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow trim of internal_holes (houses) when producing geotiff outputs using Make_Geotif #167

Merged
merged 2 commits into from Mar 10, 2018

Conversation

davekennewell
Copy link
Contributor

These changes follow the same design pattern as the trimming function for the "bounding_polygon", with 2 differences:

  • internal_holes is a list of polygons, rather than a single polygon
  • cutting an internal_hole uses the "inside_polygon" function rather than "outside_polygon" function used by the "bounding_polygon" when it trims.

@coveralls
Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage decreased (-0.002%) to 42.592% when pulling 12b8fe8 on Hydrata:master into b21ea25 on GeoscienceAustralia:master.

…conda builds) (#2)

* replace deprecated backticks with __repr__() format in test

* checking type to debug conda environment tests

* testing string encoding

* testing string encoding2

* testing string char by char

* testing with removed space for conda variable

* testing with removed space for conda variable2

* testing with removed space for conda variable3

* added testcase where removal of leading spaces is allowed (occurs on conda builds)
@stoiver stoiver merged commit ca67e86 into GeoscienceAustralia:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants