New issue 28

[acer8]

Hello Steve,

Thanks for your previous comments. I have created this new branch New_issue_28 in my forked anuga repo. This only contains the changes in quantity.py and test_quantity.py. Hopefully the issue can now be fixed!

Cheers

Hongji

[stoiver]

Your code is not passing our continuous integration tests (ie runtests.py has errors).

In future make sure runtests passes all the tests before making a pull request.

But the error looks fairly simple to fix up, quantity.py", line 908, in set_values has
max_read_lines = default_blocik_line_size
and obviously it should be
max_read_lines = default_block_line_size

Can you make the change and push your updated change to your repos.

Thanks
Steve

[acer8]

Hello Steve,

Thanks for let me know. I have fixed the typo and the runtests.py was run successfully in my local machine. I will make sure all the tests pass before making pull requests next time.

Cheers

Hongji