De2 mass protection #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoiver
added a commit
that referenced
this pull request
Oct 9, 2015
De2 mass protection. This resolves issue #69
stoiver
added a commit
that referenced
this pull request
Jan 11, 2021
Fix newlines in order_boundary and interpolate. Fix PermissionError in test_fit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem using DE2, where the update of areas with zero depth of water would actually create negative water depths if using DE2.
This came down to a calculation in DE2 of the form
Q_new = 2/3 Q_1 + 1/3 Q_old
This was changed to
Q_new = 1/3 ( 2 Q_1 + Q_old),
which seems to have alleviated the problem.