Add ensemble tide modelling functionality to model_tides
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbibt
changed the title
model_tides
robbibt
requested review from
BexDunn,
erialC-P,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA,
margaretharrison,
vnewey,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BexDunn
requested changes
Jun 13, 2024
robbibt
commented
Jun 14, 2024
| lambda x: pd.Series({"start": start_point, "end": x}) | ||
| if x.type == "Point" | ||
| else pd.Series({"start": None, "end": None}) | ||
| lambda x: ( |
There was a problem hiding this comment.
Just Black formatting stuff, can ignore this
robbibt
commented
Jun 14, 2024
| lambda x: pd.Series({"start": x.geoms[0], "end": x.geoms[-1]}) | ||
| if x.type == "MultiPoint" | ||
| else pd.Series({"start": None, "end": None}) | ||
| lambda x: ( |
There was a problem hiding this comment.
Just Black formatting stuff, can ignore this
| @@ -542,25 +717,26 @@ def model_tides( | |||
| results stacked vertically along "tide_model" and "tide_m" | |||
| columns), or wide format (with a column for each tide model). | |||
| Defaults to "long". | |||
| epsg : int, DEPRECATED | |||
There was a problem hiding this comment.
Removed this deprecated param
erialC-P
reviewed
Jun 17, 2024
erialC-P
approved these changes
Jun 17, 2024
erialC-P
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Add updated `xr_regression` function for multi-dimensional linear regression (#1226) * Add updated xr_regression function * Add dask support for lazy computation * Set dtypes * Update docstring * Update docstring * Add MAD outliers * Update docstring * Remove lag functionality * Update docstrings * Add better error handling * Update stream gauge corr notebook to use new func * Adding DEAfrica Wetland Turbidity notebook for Australian study site (#1175) * Adding DEAfrica Wetland Turbidity notebook for Australian study site * change all instances of NDTI to NDTI2 to reflect usage at top of notebook * update notebook to use Collection 3 WO Statistics * rerun notebook --------- Co-authored-by: BexDunn <bex.dunn@ga.gov.au> * Add spatial interpolation with `xr_interpolate` notebook (#1233) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook * Remove coastal files from branch * Add points data * Review feedback; * Add p param to IDW * Fix test * Updates to product notebook Knowledge Hub links and DEA notebook content (#1221) * Move KH links into consistent alert box format * Update DEA notebook * Minor wording updates * Minor wording * Temporarily remove STAC notebook from tests * Add ensemble tide modelling functionality to `model_tides` (#1231) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook --------- Co-authored-by: Matt-dea <129345253+Matt-dea@users.noreply.github.com> Co-authored-by: BexDunn <bex.dunn@ga.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements some major changes to our coastal tide modelling functions, to support new "ensemble" tide modelling functionality that combines multiple input tide models into a single higher quality output.
Key changes include:
dea_tools.coastal.model_tidesfunction, that combines multiple tide models using external model ranking data to identify the best performing models locally (the "ensemble" model generation can be customised by providing custom functions via theensemble_funcparam). By implementing "ensemble" functionality inmodel_tides, it automatically becomes available inpixel_tidesand other downstream functions we use for generating coastal datasets.model_tidesandpixel_tides