Add spatial interpolation with xr_interpolate notebook
#1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
robbibt
requested review from
BexDunn,
erialC-P,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA,
margaretharrison,
vnewey,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
uchchwhash
approved these changes
Jun 13, 2024
BexDunn
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
LGTM, really useful notebook with lots of cool bits. Only comments would be, when referring to 'z' value, you could keep describing it as 'our variable of interest z' or similar as I kept thinking it was elevation (it could be elevation) because of naming conventions, and that I think that the IDW power parameter is often referred to as 'p', yet we refer to it as 'k'. I think that's ok, as long as we are consistent. Overall its beautiful, useful, and well documented, and I'm happy to approve as is.
|
Yep, great suggestion! Will update, thanks @BexDunn! |
erialC-P
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Add updated `xr_regression` function for multi-dimensional linear regression (#1226) * Add updated xr_regression function * Add dask support for lazy computation * Set dtypes * Update docstring * Update docstring * Add MAD outliers * Update docstring * Remove lag functionality * Update docstrings * Add better error handling * Update stream gauge corr notebook to use new func * Adding DEAfrica Wetland Turbidity notebook for Australian study site (#1175) * Adding DEAfrica Wetland Turbidity notebook for Australian study site * change all instances of NDTI to NDTI2 to reflect usage at top of notebook * update notebook to use Collection 3 WO Statistics * rerun notebook --------- Co-authored-by: BexDunn <bex.dunn@ga.gov.au> * Add spatial interpolation with `xr_interpolate` notebook (#1233) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook * Remove coastal files from branch * Add points data * Review feedback; * Add p param to IDW * Fix test * Updates to product notebook Knowledge Hub links and DEA notebook content (#1221) * Move KH links into consistent alert box format * Update DEA notebook * Minor wording updates * Minor wording * Temporarily remove STAC notebook from tests * Add ensemble tide modelling functionality to `model_tides` (#1231) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook --------- Co-authored-by: Matt-dea <129345253+Matt-dea@users.noreply.github.com> Co-authored-by: BexDunn <bex.dunn@ga.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the
xr_interpolatefunction with new interpolation functionality, and adds a new Jupyter Notebook guide to using the function to spatially interpolate data.Key changes include:
dea_tools.spatial.idwInverse Weighted Distance Interpolation function, and updateddea_tools.spatial.xr_interpolateto use this instead of previous bespoke code. Supports spatially interpolating both 1D and 2D input values (e.g. interpolating one or multiple datasets into the spatial extents of another).xr_interpolate(coordinates where being passed around in the wrong order)xr_interpolate andidw` functionsIDW interpolation example:
Checklist
Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended).NCIandDEA Sandbox(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment onlyline below the notebook title to reflect the environments the notebook is compatible with