Merge pull request #4045 from GeotrekCE/fix_new_flatpages_open_in_sam…

…e_tab New menu items with page target open it in same tab
GeotrekCE · Apr 4, 2024 · fb42f7e · fb42f7e
2 parents 28fec19 + afe4177
commit fb42f7e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -5,6 +5,9 @@ CHANGELOG
 2.104.1+dev (XXXX-XX-XX)
 ------------------------
 
+**Bug fix**
+
+- New menu items targeting static page now open it in the same tab
 
 
 2.104.1 (2024-04-03)

diff --git a/geotrek/flatpages/static/flatpages/js/menu_item_fieldsets.js b/geotrek/flatpages/static/flatpages/js/menu_item_fieldsets.js
@@ -59,6 +59,11 @@ function cleanSubmission() {
         });
     };
 
+    let uncheckOpenInNewTab = function() {
+        let checkbox = document.querySelector("input[name=open_in_new_tab]");
+        checkbox.checked = false;
+    }
+
     let erasePageField = function() {
         let page_select = document.querySelector("select[name=\"page\"]");
         page_select.value = undefined;
@@ -67,6 +72,7 @@ function cleanSubmission() {
     let targetType = document.getElementById("id_target_type").value;
     if (targetType === "page") {
         eraseLinkUrlFields();
+        uncheckOpenInNewTab();
     } else if (targetType === "link") {
         erasePageField();
     } else {