Fix problems of merge path and aggregations tests #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LePetitTim
force-pushed
the
fix_merge_path
branch
from
c5f4f80
to
b850097
Compare
LePetitTim
force-pushed
the
fix_merge_path
branch
from
b850097
to
930b5be
Compare
gutard
suggested changes
Jun 25, 2018
…into fix_merge_path
gutard
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a test for #1723, which shows that the bug of merging with topologies have a normal behaviour.
I fix the bug which remove a path when we merge 2 paths with a 3rd path on the point of merge. #1747