Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parser TouristicEvent Apidae Parser + Refactor ApidaeParser #1816

Merged
merged 15 commits into from Jan 8, 2019
Merged

Add parser TouristicEvent Apidae Parser + Refactor ApidaeParser #1816

merged 15 commits into from Jan 8, 2019

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Dec 14, 2018 •
edited

It fixes a problem with m2m_fields and "fk_fields" : was not able to create a new element. in this cases

@coveralls
Copy link

coveralls commented Dec 14, 2018 •
edited

Coverage Status

Coverage increased (+0.03%) to 89.958% when pulling 39345a2 on modify_parsers into 7d10d0f on master.

submarcos
submarcos requested changes Dec 17, 2018
View reviewed changes
geotrek/common/parsers.py Outdated Show resolved Hide resolved
geotrek/tourism/tests/test_parsers.py Show resolved Hide resolved
geotrek/tourism/tests/test_parsers.py Show resolved Hide resolved
gutard
gutard suggested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@gutard gutard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avant de merger, il faut vérifier que la fonctionnalité de delete n'est pas cassée et ne supprime pas des objets qui ne devraient pas l'être.

geotrek/common/parsers.py Show resolved Hide resolved
geotrek/common/parsers.py Outdated Show resolved Hide resolved
geotrek/common/parsers.py Outdated Show resolved Hide resolved
geotrek/tourism/parsers.py Outdated Show resolved Hide resolved
geotrek/tourism/parsers.py Outdated Show resolved Hide resolved
geotrek/tourism/parsers.py Outdated Show resolved Hide resolved
geotrek/tourism/tests/test_parsers.py Show resolved Hide resolved
geotrek/tourism/tests/test_parsers.py Show resolved Hide resolved
@LePetitTim LePetitTim merged commit ee275c2 into master Jan 8, 2019
@LePetitTim LePetitTim deleted the modify_parsers branch January 6, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@submarcos submarcos submarcos requested changes

@gutard gutard gutard approved these changes

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LePetitTim @coveralls @gutard @submarcos