Add common sql default value, remove db_column french #3055

LePetitTim · 2022-04-05T16:41:54Z

No description provided.

cypress · 2022-04-05T17:01:24Z

Test summary

20 • 0 • 0 • 0

Run details


Project	Geotrek-admin
Status	Passed
Commit	`34702e5`
Started	Apr 8, 2022 1:42 PM
Ended	Apr 8, 2022 1:44 PM
Duration	02:45 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

codecov · 2022-04-05T17:19:29Z

Codecov Report

Merging #3055 (34702e5) into master (c5aba15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3055   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         261      261           
  Lines       17809    17809           
=======================================
  Hits        17361    17361           
  Misses        448      448

Impacted Files	Coverage Δ
geotrek/common/models.py	`98.72% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5aba15...34702e5. Read the comment docs.

submarcos · 2022-04-06T08:41:57Z

geotrek/common/models.py

                              help_text=_("Original creator"))
    title = models.CharField(blank=True, default='', max_length=128,
-                             db_column='titre', verbose_name=_(u"Filename"),
+                             verbose_name=_(u"Filename"),


Suggested change

verbose_name=_(u"Filename"),

verbose_name=_("Filename"),

submarcos · 2022-04-06T08:42:04Z

geotrek/common/models.py

                             help_text=_("Renames the file"))
    legend = models.CharField(blank=True, default='', max_length=128,
-                              db_column='legende', verbose_name=_(u"Legend"),
+                              verbose_name=_(u"Legend"),


Suggested change

verbose_name=_(u"Legend"),

verbose_name=_("Legend"),

camillemonchicourt · 2022-04-08T11:59:41Z

Attention @IdrissaD, dans la prochaine version, on ajoute des valeurs par défaut sur tous les champs où cela est pertinent.
Et on en profite pour renommer en anglais les champs de la table des fichiers liés.

Il faudra alors revoir la vue du schéma de données qui fait appel à ces champs en français : https://github.com/PnX-SI/schema_randonnee/blob/master/geotrek/v_treks_schema.sql

@LePetitTim pour ceux qui ont des vues ou autres utilisant la BDD, il faudrait indiquer dans le Changelog les champs des attachments qui ont été renommés en anglais.

camillemonchicourt · 2022-04-08T12:05:14Z

geotrek/common/sql/post_90_defaults.sql

+ALTER TABLE common_attachment ALTER COLUMN uuid SET DEFAULT gen_random_uuid();
+ALTER TABLE common_attachment ALTER COLUMN attachment_video SET DEFAULT '';
+ALTER TABLE common_attachment ALTER COLUMN attachment_link SET DEFAULT '';
+-- filetype


Mettre une valeur par défaut sur le champs attachment_file, si on ne remplit que attachment_link ?

camillemonchicourt · 2022-04-08T12:07:27Z

geotrek/common/sql/post_90_defaults.sql

+ALTER TABLE common_attachment ALTER COLUMN starred SET DEFAULT False;
+ALTER TABLE common_attachment ALTER COLUMN is_image SET DEFAULT False;
+ALTER TABLE common_attachment ALTER COLUMN date_insert SET DEFAULT now();
+ALTER TABLE common_attachment ALTER COLUMN date_update SET DEFAULT now();


Supprimer le champs creation_date de cette table qui ne semble pas utilisé et semble redondant avec date_insert ?

camillemonchicourt · 2022-04-08T12:13:06Z

geotrek/core/sql/post_90_defaults.sql

+-- geom
+ALTER TABLE core_topology ALTER COLUMN uuid SET DEFAULT gen_random_uuid();
+-- geom_3d
+ALTER TABLE core_topology ALTER COLUMN "length" SET DEFAULT 0.0;


Ligne redondante, définie quelques lignes plus haut.

submarcos · 2022-04-08T10:17:35Z

geotrek/core/sql/post_90_defaults.sql

+ALTER TABLE core_path ALTER COLUMN eid SET DEFAULT '';
+ALTER TABLE core_path ALTER COLUMN draft SET DEFAULT False;
+ALTER TABLE core_path ALTER COLUMN uuid SET DEFAULT gen_random_uuid();
+ALTER TABLE core_path ALTER COLUMN geom_3d SET DEFAULT NULL;


Suggested change

ALTER TABLE core_path ALTER COLUMN geom_3d SET DEFAULT NULL;

ALTER TABLE core_path ALTER COLUMN geom_3d SET DEFAULT NULL;

default is already null on nullable columns

submarcos · 2022-04-08T10:31:47Z

geotrek/core/sql/post_90_defaults.sql

+ALTER TABLE core_topology ALTER COLUMN geom_need_update SET DEFAULT FALSE;
+-- geom
+ALTER TABLE core_topology ALTER COLUMN uuid SET DEFAULT gen_random_uuid();
+ALTER TABLE core_topology ALTER COLUMN geom_3d SET DEFAULT NULL;


Suggested change

ALTER TABLE core_topology ALTER COLUMN geom_3d SET DEFAULT NULL;

ALTER TABLE core_topology ALTER COLUMN geom_3d SET DEFAULT NULL;

idem

submarcos · 2022-04-08T10:32:02Z

geotrek/maintenance/sql/post_90_defaults.sql

+-- InterventionStatus
+---------------------
+-- status
+ALTER TABLE maintenance_interventionstatus ALTER COLUMN "order" SET DEFAULT NULL;


Suggested change

ALTER TABLE maintenance_interventionstatus ALTER COLUMN "order" SET DEFAULT NULL;

ALTER TABLE maintenance_interventionstatus ALTER COLUMN "order" SET DEFAULT NULL;

IDEM

Add common sql default value, remove db_column french

c8c15e0

submarcos reviewed Apr 6, 2022

View reviewed changes

LePetitTim added 25 commits April 6, 2022 11:55

Add comment common accessiility, add core defaults

336df61

Fix sql core default

0e8d385

Add sql default diving

ad2ce84

Fix sql diving default

392d340

Add default sql feedback

e25a272

Add default sql flatpages

306d6c7

Add default sql infrastructure

5a69b9f

Add default sql land

d8d5161

Add default sql maintenance

e707e21

Add default sql outdoor

7a630f9

Fix json default value

6344903

Remove outdoor default in wrong sql file

fd18c74

Add default sql sensitivity

4a9a998

Fix default column outdoor rating

e2ac216

Add default sql signage

8466689

Add default sql tourism

0c202ae

Add default sql trekking

eedebe8

Add default sql zoning

a8c2591

Add test sql common

7e6c811

Add test sql core

5468129

Fix alter table wrong table trekking

645db43

Add documentation development

30e98d1

Add changelog

196716a

Fix test and flake8

76c67ab

Fix model useless unicode

e40d1a1

LePetitTim added 2 commits April 8, 2022 11:38

Update paperclip without french

bb886b9

Add change paperclip in changelog

8200349

LePetitTim requested a review from submarcos April 8, 2022 09:43

Remove useless default null

859cc8d

camillemonchicourt reviewed Apr 8, 2022

View reviewed changes

LePetitTim and others added 4 commits April 8, 2022 15:07

Add change about changement of field fr to en

3401838

Fix sql default

c09a5a0

Change default value type feedback (mandatory)

fd9e1e5

Complete changelog

34702e5

submarcos approved these changes Apr 8, 2022

View reviewed changes

LePetitTim merged commit 9632f58 into master Apr 8, 2022

LePetitTim deleted the add_default_values_db branch April 8, 2022 14:11

IdrissaD mentioned this pull request Apr 11, 2022

Mettre à jour noms des champs médias dans la vue SQL PnX-SI/schema_randonnee#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add common sql default value, remove db_column french #3055

Add common sql default value, remove db_column french #3055

LePetitTim commented Apr 5, 2022

cypress bot commented Apr 5, 2022 •

edited

codecov bot commented Apr 5, 2022 •

edited

submarcos Apr 6, 2022

submarcos Apr 6, 2022

camillemonchicourt commented Apr 8, 2022

camillemonchicourt Apr 8, 2022

camillemonchicourt Apr 8, 2022

camillemonchicourt Apr 8, 2022

submarcos Apr 8, 2022

submarcos Apr 8, 2022

submarcos Apr 8, 2022

	ALTER TABLE core_path ALTER COLUMN geom_3d SET DEFAULT NULL;
	ALTER TABLE core_path ALTER COLUMN geom_3d SET DEFAULT NULL;

	ALTER TABLE core_topology ALTER COLUMN geom_3d SET DEFAULT NULL;
	ALTER TABLE core_topology ALTER COLUMN geom_3d SET DEFAULT NULL;

	ALTER TABLE maintenance_interventionstatus ALTER COLUMN "order" SET DEFAULT NULL;
	ALTER TABLE maintenance_interventionstatus ALTER COLUMN "order" SET DEFAULT NULL;

Add common sql default value, remove db_column french #3055

Add common sql default value, remove db_column french #3055

Conversation

LePetitTim commented Apr 5, 2022

cypress bot commented Apr 5, 2022 • edited

Test summary

Run details

codecov bot commented Apr 5, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camillemonchicourt commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cypress bot commented Apr 5, 2022 •

edited

codecov bot commented Apr 5, 2022 •

edited