Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS of Altimetry #3657

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Update CSS of Altimetry #3657

merged 2 commits into from
Sep 1, 2023

Conversation

Huquette
Copy link
Contributor

This pull request changes how altitude profiles look. Right now, they look like this:

OLD_ALTIMETRY

OLD_ALTIMETRY_DEFILE

After this change, they will look like this:

NEW_ALTIMETRY

NEW_ALTIMETRY_DEFILE

As a result, the altitude profile will show higher up on the page, which let some space for the attribution mark.

@Huquette Huquette self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa007e1) 98.29% compared to head (d939c7a) 98.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3657   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         292      292           
  Lines       21720    21720           
=======================================
  Hits        21350    21350           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Aug 11, 2023

Passing run #6948 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge d939c7a into aa007e1...
Project: Geotrek-admin Commit: 3be5beeac7 ℹ️
Status: Passed Duration: 04:31 💡
Started: Sep 1, 2023 9:25 AM Ended: Sep 1, 2023 9:30 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Huquette Huquette marked this pull request as ready for review August 11, 2023 12:05
@babastienne
Copy link
Member

Same as Georiviere/Georiviere-admin#210

@Huquette Huquette added this to Freeze in BPO-Tickets Aug 14, 2023
@Huquette Huquette moved this from Freeze to Done in BPO-Tickets Aug 14, 2023
@Huquette Huquette merged commit dcfa2cf into master Sep 1, 2023
15 checks passed
@Huquette Huquette deleted the fix_altrimetry_css branch September 1, 2023 10:12
@babastienne babastienne moved this from Done to Merged in BPO-Tickets Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants