Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filters #3813

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Refactor filters #3813

merged 6 commits into from
Oct 27, 2023

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

@cypress
Copy link

cypress bot commented Oct 27, 2023

Passing run #7491 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 6420a7b into 26d1e8e...
Project: Geotrek-admin Commit: 4fff869360 ℹ️
Status: Passed Duration: 04:52 💡
Started: Oct 27, 2023 10:01 AM Ended: Oct 27, 2023 10:05 AM

Review all test suite changes for PR #3813 ↗︎

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26d1e8e) 98.33% compared to head (6420a7b) 98.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3813      +/-   ##
==========================================
- Coverage   98.33%   98.33%   -0.01%     
==========================================
  Files         292      292              
  Lines       21829    21792      -37     
==========================================
- Hits        21466    21429      -37     
  Misses        363      363              
Files Coverage Δ
geotrek/cirkwi/filters.py 100.00% <100.00%> (ø)
geotrek/common/filters/__init__.py 100.00% <100.00%> (ø)
geotrek/common/filters/fields.py 100.00% <100.00%> (ø)
geotrek/core/filters.py 100.00% <ø> (ø)
geotrek/infrastructure/filters.py 100.00% <100.00%> (ø)
geotrek/maintenance/filters.py 100.00% <100.00%> (ø)
geotrek/outdoor/filters.py 100.00% <ø> (ø)
geotrek/sensitivity/filters.py 100.00% <ø> (ø)
geotrek/signage/filters.py 100.00% <100.00%> (ø)
geotrek/tourism/filters.py 98.03% <ø> (-0.21%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos marked this pull request as ready for review October 27, 2023 10:09
@submarcos submarcos requested a review from a team October 27, 2023 10:09
@submarcos submarcos merged commit 6cf5f1f into master Oct 27, 2023
14 checks passed
@submarcos submarcos deleted the refactor_filters branch October 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant