Fix error in cities cache key prefix
#3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #8221 ↗︎
Details:
Review all test suite changes for PR #3856 ↗︎ |
|||||||||||||||
It was harmless because the other parts of the cache key prevent retrieving the wrong content. No visible change for users excepted some slow requests to rebuild cached values.
submarcos
force-pushed
the
bug_fix-cache-key-prefix-for-cities
branch
from
ec49d25
to
ab8f0b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3856 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 294 294
Lines 22336 22336
=======================================
Hits 21969 21969
Misses 367 367 ☔ View full report in Codecov by Sentry. |
babastienne
changed the title
cities cache key prefixcities cache key prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was harmless because the other parts of the cache key prevent retrieving the wrong content. No visible change for users excepted some slow requests to rebuild cached values.
Checklist
My code respects the Definition of done available in the Development section of the documentationI have performed a self-review of my codeI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works.I added an entry in the changelog fileThe title of my PR mentionned the issue associated