-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG] Fix sublanguage usage (refs #3801) #3868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chatewgne
changed the title
Fix compat migration sub languages
💫 [IMPR] Fix sublanguage usage (refs #3801)
Dec 27, 2023
Chatewgne
force-pushed
the
fix_compat_migration_sub_languages
branch
4 times, most recently
from
December 27, 2023 11:09
2352621
to
957fa27
Compare
Chatewgne
changed the title
💫 [IMPR] Fix sublanguage usage (refs #3801)
🐛 [BUG] Fix sublanguage usage (refs #3801)
Dec 27, 2023
Passing run #7750 ↗︎
Details:
Review all test suite changes for PR #3868 ↗︎ |
Chatewgne
force-pushed
the
fix_compat_migration_sub_languages
branch
from
December 27, 2023 13:44
957fa27
to
7c5ad38
Compare
Chatewgne
force-pushed
the
fix_compat_migration_sub_languages
branch
from
January 5, 2024 09:24
7c5ad38
to
464ea1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 292 292
Lines 22048 22067 +19
=======================================
+ Hits 21684 21703 +19
Misses 364 364 ☔ View full report in Codecov by Sentry. |
submarcos
reviewed
Jan 5, 2024
Chatewgne
force-pushed
the
fix_compat_migration_sub_languages
branch
from
January 11, 2024 09:24
464ea1a
to
029abe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sublanguage usage (refs #3801)
Finishing changes started in PRs #3830 and #3802
Related Issue
#3801
Checklist