Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix sublanguage usage (refs #3801) #3868

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Dec 27, 2023

Fix sublanguage usage (refs #3801)
Finishing changes started in PRs #3830 and #3802

Related Issue

#3801

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne changed the title Fix compat migration sub languages 💫 [IMPR] Fix sublanguage usage (refs #3801) Dec 27, 2023
@Chatewgne Chatewgne force-pushed the fix_compat_migration_sub_languages branch 4 times, most recently from 2352621 to 957fa27 Compare December 27, 2023 11:09
@Chatewgne Chatewgne changed the title 💫 [IMPR] Fix sublanguage usage (refs #3801) 🐛 [BUG] Fix sublanguage usage (refs #3801) Dec 27, 2023
Copy link

cypress bot commented Dec 27, 2023

Passing run #7750 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 029abe7 into 17c1396...
Project: Geotrek-admin Commit: bce5eeb5ea ℹ️
Status: Passed Duration: 02:04 💡
Started: Jan 11, 2024 9:35 AM Ended: Jan 11, 2024 9:37 AM

Review all test suite changes for PR #3868 ↗︎

@Chatewgne Chatewgne force-pushed the fix_compat_migration_sub_languages branch from 957fa27 to 7c5ad38 Compare December 27, 2023 13:44
@Chatewgne Chatewgne force-pushed the fix_compat_migration_sub_languages branch from 7c5ad38 to 464ea1a Compare January 5, 2024 09:24
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41e35fe) 98.34% compared to head (029abe7) 98.35%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3868   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         292      292           
  Lines       22048    22067   +19     
=======================================
+ Hits        21684    21703   +19     
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

conf/env.in Outdated Show resolved Hide resolved
@Chatewgne Chatewgne force-pushed the fix_compat_migration_sub_languages branch from 464ea1a to 029abe7 Compare January 11, 2024 09:24
@Chatewgne Chatewgne merged commit b7575d8 into master Jan 11, 2024
16 checks passed
@Chatewgne Chatewgne deleted the fix_compat_migration_sub_languages branch January 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants