Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance appears several times on some zoning filters #3881 #3882

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

juggler31
Copy link
Contributor

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@juggler31 juggler31 linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link

cypress bot commented Jan 8, 2024

Passing run #7742 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 41e35fe into 67667a9...
Project: Geotrek-admin Commit: 1a2af9ab82 ℹ️
Status: Passed Duration: 02:06 💡
Started: Jan 8, 2024 4:02 PM Ended: Jan 8, 2024 4:04 PM

Review all test suite changes for PR #3882 ↗︎

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67667a9) 98.34% compared to head (41e35fe) 98.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3882   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         292      292           
  Lines       22048    22048           
=======================================
  Hits        21684    21684           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 requested a review from a team January 9, 2024 09:46
@babastienne babastienne changed the title fix: Maintenance appears several times on some zoning filters #3881 Maintenance appears several times on some zoning filters #3881 Jan 10, 2024
@juggler31 juggler31 merged commit 17c1396 into master Jan 10, 2024
15 checks passed
@juggler31 juggler31 deleted the chantiers_en_doublon_issue_3881 branch January 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chantiers en doublon en filtrant sur communes ou secteurs
3 participants