Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove tmp file on test after fix encoding file #3934

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Feb 13, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Feb 13, 2024

Passing run #7996 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge aea0582 into 854bc2b...
Project: Geotrek-admin Commit: 8d4eb4dff4 ℹ️
Status: Passed Duration: 02:06 💡
Started: Feb 15, 2024 8:49 AM Ended: Feb 15, 2024 8:51 AM

Review all test suite changes for PR #3934 ↗︎

@juggler31 juggler31 requested a review from a team February 13, 2024 14:01
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b514749) 98.34% compared to head (aea0582) 98.34%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3934   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         294      294           
  Lines       22262    22263    +1     
=======================================
+ Hits        21894    21895    +1     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the fix_test_encoding_utf8 branch 2 times, most recently from e44c395 to ea65656 Compare February 14, 2024 14:57
@juggler31 juggler31 merged commit 22461b7 into master Feb 16, 2024
14 checks passed
@juggler31 juggler31 deleted the fix_test_encoding_utf8 branch February 16, 2024 11:25
@babastienne babastienne changed the title 🐛 [FIX] remove tmp file on test after fix encoding file [FIX] remove tmp file on test after fix encoding file Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants