Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to Cirkwi trek exports (refs #3947) #3958

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Feb 23, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Feb 23, 2024

Passing run #8067 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 39a1258 into c46c2e5...
Project: Geotrek-admin Commit: aa9eb60538 ℹ️
Status: Passed Duration: 02:12 💡
Started: Feb 23, 2024 2:31 PM Ended: Feb 23, 2024 2:33 PM

Review all test suite changes for PR #3958 ↗︎

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (c46c2e5) to head (39a1258).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3958   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         294      294           
  Lines       22285    22292    +7     
=======================================
+ Hits        21918    21925    +7     
  Misses        367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne merged commit ad649e5 into master Feb 26, 2024
15 checks passed
@Chatewgne Chatewgne deleted the feat_cirkwi_filter_eids branch February 26, 2024 09:24
@babastienne babastienne changed the title ✨ [FEAT] Add filter to Cirkwi trek exports (refs #3947) Add filter to Cirkwi trek exports (refs #3947) Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants