Sort attachments in API V2 for Outdoor Sites and Touristic Contents (refs #4071) #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4072 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 284 284
Lines 20785 20785
=======================================
Hits 20451 20451
Misses 334 334 ☔ View full report in Codecov by Sentry. |
Passing run #8753 ↗︎
Details:
Review all test suite changes for PR #4072 ↗︎ |
|||||||||||||||
Chatewgne
reviewed
Apr 15, 2024
| @@ -488,7 +488,7 @@ def get_description_teaser(self, obj): | |||
| return get_translation_or_dict('description_teaser', self, obj) | |||
|
|
|||
| class TouristicContentSerializer(TouristicModelSerializer): | |||
| attachments = AttachmentSerializer(many=True) | |||
| attachments = AttachmentSerializer(many=True, source='sorted_attachments') | |||
There was a problem hiding this comment.
Shouldn't we also add it on Infrastructure, SensitiveArea ?
There was a problem hiding this comment.
The attribute sorted_attachments is available with the PicturesMixin.
The PicturesMixin is not associated with the following objects (therefore we cannot do the same modification) :
- Signage
- Infrastructure
- SensitiveArea
Chatewgne
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#4071
Checklist