Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define default placeholder to SelectableDropdown #935

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Jun 29, 2023

Fix the display of SelectableDropdown if placeholder props is set to null.

The problem may occur during the following steps in GTA:

  • Defining a touristicContent category
  • Creating an unnamed list
  • Creating more than 9 types linked to this list (in this case, label filters become drop-down lists in GTR).

This PR corrects this behavior by defining a default "Select" placeholder if the list has no name.

@dtrucs dtrucs requested a review from a team July 3, 2023 12:53
@dtrucs dtrucs merged commit 92907da into develop Jul 4, 2023
1 check passed
@camillemonchicourt camillemonchicourt deleted the Define-default-placeholder-to-Selectable-dropdown branch July 4, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant