Rename to something other than JSON5, to not be incorrect or misleading #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON5 is a specification. Anything carrying that name should adhere to the spec. In addition, the name JSON5 has special meaning, which is not true of this fork. As I stated in my suggested changes to this fork's Into:
JSON5 is designed to be valid ES5 Javascript (hence the name), as its maintainer points out:
This fork does not maintain this guarantee. Though it includes support for ES6-style multiline string template literals, it shouldn't be named JSON6 either because it includes other syntax that is not valid ES6.
As your own Pull Request Template says:
While it is compatible in functionality (being a superset), it is not compatible in name. It needs a different name, for the same reason that JSON5 is "JSON5" not "JSON", for the same reasons
jsonc
,Hjson
, andYAML
have their own names.