Fix sorting of fields in an inline type #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drag & drop operaiton in the backend re-orders the form elements, such that the iteration in the Mask storage update is in the correct order, but that order is destroyed by sortJson. This fixed sorting is valuable to version control, so instead this commit introduces an extra field 'order' in the column of the inline type. This is used in the TCA generator and before the backend view renders.
ghost
|
Thank you! :) |
ghost
mentioned this pull request
|
Someone tested with"Reapeating" in "Repeating"? mask 3.3.3 |
|
Yes, I can also confirm that first Repeating sorting is fine, second Repeating sorting is not in mask 3.3.3. Also in the second repeating element Field that should be used as label for inline element and Path to icon for irre elements are not working too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drag & drop operaiton in the backend re-orders the form elements,
such that the iteration in the Mask storage update is in the correct
order, but that order is destroyed by sortJson. This fixed sorting is
valuable to version control, so instead this commit introduces an extra
field 'order' in the column of the inline type. This is used in the TCA
generator and before the backend view renders.
Additionally, I removed a superfluous initSortable call in the backend JavaScript.
The sortable widget has already been initialized, no need to re-initialize it
with some new functions that do exactly the same.