[BUGFIX] Prevent error when be:uri.editRecord is used in preview template

[nitori]

Without the request on the rendering context, the uri.editRecord and link.editRecord ViewHelpers of the backend module are unable to automatically generate a returnUrl.

In the case of uri.editRecord we get an exception in the page module, and with the link.editRecord we'll end up on a blank page, when trying to use the close button to return to the previous page.

---

Not sure if there is a better way to get the TYPO3_REQUEST than through $GLOBALS. Maybe injection?

Also not sure if that perhaps is more of a TYPO3 core bug.

Anyway, I encountered this, because I like to add direct links to nested Content Elements if present right in the Page Module.

An example preview template taken from an Accordion Element:

<f:if condition="{data.tx_mask_accordion}">
    <f:for each="{data.tx_mask_accordion}" as="accordion" iteration="i">
        <div class="well well-sm">
            <div>
                <strong>{accordion.tx_mask_header}</strong>
            </div>
            <f:if condition="{accordion.tx_mask_content}">
                <f:for each="{accordion.tx_mask_content}" as="ce">
                    <f:alias map="{editLink: '{be:uri.editRecord(uid: ce.uid, table: \'tt_content\')}'}">
                        <div>
                            <span title="id={ce.uid}" data-toggle="tooltip" data-placement="top">
                                <core:iconForRecord row="{ce}" table="tt_content"/>
                            </span>
                            <a href="{editLink}" data-toggle="tooltip" data-placement="top" title="id={ce.uid}">
                                <core:icon identifier="actions-open"/>
                            </a>
                            <a href="{editLink}">
                                <f:render section="Label" arguments="{ce: ce}"/>
                            </a>
                        </div>
                    </f:alias>
                </f:for>
            </f:if>
        </div>
    </f:for>
</f:if>

If it wasn't the uri-ViewHelper but the link one instead, I'd probably never have noticed this error.

[nitori]

Also, it seems to only appear in TYPO3 12.

And I haven't tested this specific issue on TYPO3 11
It seems to work just fine.

[nhovratov]

Unfortunately, there is no other way. The Event doesn't provide the request object, so using the global is required.
This patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75779
removed the request (with attached extbase context) completely.

[nhovratov]

Thanks Lars, I will wait until next week for the next release. Maybe something else will pop up.