Skip to content

Commit

Permalink
upgrade bulma to 0.7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@GerritSommer
GerritSommer committed Dec 11, 2018
1 parent 4d2f03d commit 687c484
Show file tree
Hide file tree
Showing 2 changed files with 14,099 additions and 13,029 deletions.
Loading

3 comments on commit 687c484

@michaellenaghan
Copy link

@michaellenaghan michaellenaghan commented on 687c484 Jan 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was meant to make the Bulma version 0.7.2, but the blueprint accepts old versions, down to 0.5.3.

@GerritSommer
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @michaellenaghan, sorry I didn't answer.
I will read abit through that semver-stuff, so I properly understand your changes and then add your commit. It seems I don't get around it this time ;-)

Thanks for the help

@michaellenaghan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear: this points to one of your old commits, not my proposed change. The intention of the commit was presumably to bump Bulma to 0.7.2, but it doesn't actually affect users of this package. The users are affected by what is in the blueprint:

return this.addPackagesToProject([
  { name: 'bulma', target: '^0.5.3' },
  { name: 'ember-cli-sass', target: '^6.1.2' }
]);

Make sense?

Please sign in to comment.