Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an optional index manager service. #3664

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Conversation

grugnog
Copy link
Member

@grugnog grugnog commented Sep 15, 2021

This is relatively experimental and adds support for https://www.drupal.org/project/indexer. Once we have more experience with this in production, some clearer documentation on the DKAN side and a stable release of indexer, we will add it as a dependency to composer.json.

QA Steps

  • Apply patch
  • Test DKAN imports datastores normally without indexer module
  • Install indexer module
  • Test DKAN imports datastores normally with default indexer module (no-op) configuration

@dafeder
Copy link
Member

dafeder commented Sep 23, 2021

Need clearer instructions.. handing back to @grugnog for now.

@grugnog
Copy link
Member Author

grugnog commented Sep 29, 2021

@dafeder added some simplified QA instructions

Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA steps confirmed. Import with indexer enabled does throw a warning:

[warning] Invalid argument supplied for foreach() IndexManager.php:73

but this is coming from the indexer module which is still a WIP. Comfortable merging with an "experimental" disclaimer.

@dafeder dafeder merged commit e2d58b6 into 2.x Oct 12, 2021
@dafeder dafeder deleted the 3651-indexer branch October 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants