Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for datastore API #3707

Merged
merged 12 commits into from
Nov 15, 2021
Merged

More tests for datastore API #3707

merged 12 commits into from
Nov 15, 2021

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Nov 13, 2021

QA Steps

Only tests changed here so just skim the new ones to make sure they make sense and are passing.

@dafeder dafeder marked this pull request as ready for review November 15, 2021 15:18
Copy link
Contributor

@clayliddell clayliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I've added a couple of suggestions just to fix some comment typos, but otherwise approved.

@clayliddell clayliddell merged commit cab19f0 into 2.x Nov 15, 2021
@clayliddell clayliddell deleted the unbuffered-tests branch November 15, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants