Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Datastore Dashboard Controller into Form #3714

Merged
merged 11 commits into from
Dec 2, 2021
Merged

Convert Datastore Dashboard Controller into Form #3714

merged 11 commits into from
Dec 2, 2021

Conversation

clayliddell
Copy link
Contributor

@clayliddell clayliddell commented Nov 25, 2021 •
edited
Loading

  • Test coverage exists
  • Documentation exists

QA Steps

  • Create a dataset via a harvest file.
  • Ensure the DKAN instance you are working with has at least 11 datasets.
  • Navigate to the datastore dashboard.
  • Ensure only 10 datasets are showing up on the first page, and other datasets can be accessed via the pager.
  • Ensure the UUID filter is working on the datastore dashboard.
  • Ensure the harvest filter is working on the datastore dashboard.
  • Ensure links for harvest IDs on the harvest dashboard navigate to a pre-filtered datastore dashboard.

@clayliddell clayliddell changed the title Convert Dashboard Controller into Form Convert Datastore Dashboard Controller into Form Nov 29, 2021
dafeder
dafeder requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's override codeclimate on the buildFilters() method -- sometimes Drupal's just gonna Drupal -- but remove that @return

modules/datastore/src/Form/DashboardForm.php Outdated Show resolved Hide resolved
Remove unnecessary @return in DocBlock to satisfy CodeClimate
32af2ec 
Prevent CodeClimate from complaining about me using a @return comment on a method with a yield statement.
@dafeder dafeder merged commit 7122661 into 2.x Dec 2, 2021
@janette janette deleted the add-dashboard-filters branch May 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder Awaiting requested review from dafeder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clayliddell @dafeder