Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drupal's httpclient #3781

Closed
wants to merge 7 commits into from
Closed

Conversation

sandeepguntaka
Copy link

Using drupal's default http client helps in building client object with global http client config.

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

Using drupal's default http client helps in building client object with global http client config.
@dafeder
Copy link
Member

dafeder commented May 25, 2022

Hi - @sandeepguntaka open to this but as you can see it needs more work to get the tests to work. Hopefully you're able to run the tests locally and debug them? If you get the tests passing again we can probably merge this.

@sandeepguntaka
Copy link
Author

Hi - @sandeepguntaka open to this but as you can see it needs more work to get the tests to work. Hopefully you're able to run the tests locally and debug them? If you get the tests passing again we can probably merge this.

I still see an issue with mocking guzzle's client, will fix that too and push the changes soon.

@paul-m
Copy link
Contributor

paul-m commented Feb 1, 2024

It looks like this was added as part of #4084

Thanks!

@paul-m paul-m closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants