Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4075: Catch Guzzle Exception to avoid breaking harvest/dataset entry #4084

Merged
merged 5 commits into from Dec 21, 2023
Merged

#4075: Catch Guzzle Exception to avoid breaking harvest/dataset entry #4084

merged 5 commits into from Dec 21, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Dec 19, 2023 •
edited

fixes #4075

  • Injects the Guzzle HTTP client into Referencer as the http_client service.
  • Catches exceptions from the Guzzle client in Referencer::getRemoteMimeType() when trying to determine the remote file's Content-Type.
  • Amends tests.

@paul-m paul-m mentioned this pull request Dec 19, 2023
Merged
3 tasks
@paul-m paul-m marked this pull request as ready for review December 21, 2023 17:54
@paul-m paul-m requested a review from dafeder December 21, 2023 17:56
@paul-m paul-m changed the title #4075: Catch Guzzle Exception to avoid breaking harvest (round 2) #4075: Catch Guzzle Exception to avoid breaking harvest/dataset entry Dec 21, 2023
@dafeder dafeder merged commit 40f30e0 into 2.x Dec 21, 2023
12 checks passed
@dafeder dafeder deleted the remote-type-try-catch branch December 21, 2023 18:06
@paul-m paul-m mentioned this pull request Feb 1, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catch Guzzle Exception to avoid breaking harvest
3 participants
@paul-m @dafeder @stefan-korn