3791 Higher version for select_or_other #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-m
commented
Jun 10, 2022
| @@ -66,6 +66,8 @@ commands: | |||
| command: | | |||
| git --git-dir=dkan/.git --work-tree=dkan checkout "${CIRCLE_SHA1}" | |||
| dktl exec:composer -- require --no-interaction --ansi --no-update "getdkan/dkan:dev-${CIRCLE_SHA1}" | |||
| rm -rf docroot/modules/contrib/select_or_other | |||
There was a problem hiding this comment.
The fact that select_or_other was patched led to an error during the update tests. To fix this I had to have the script remove the module and then also remove the vendor directory.
janette
force-pushed
the
3791-no-patch-select_or_other
branch
2 times, most recently
from
8662bea
to
44eaf5e
Compare
janette
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3791