Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Service classes for better names #3946

Merged
merged 24 commits into from
May 3, 2023
Merged

Refactor Service classes for better names #3946

merged 24 commits into from
May 3, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Apr 21, 2023

Renames classes named Service to have more descriptive names.

The previous Service class is left as deprecated.

modules/datastore/tests/src/Mock/Container.php is removed because no test needs it.

Deprecated Class New Class
Drupal\datastore\Service Drupal\datastore\DatastoreService
Drupal\datastore\SqlEndpoint\Service Drupal\datastore\SqlEndpoint\DatastoreSqlEndpointService
Drupal\harvest\Service Drupal\harvest\HarvestService
Drupal\metastore\Service Drupal\metastore\MetastoreService

@paul-m paul-m marked this pull request as ready for review April 26, 2023 20:22
@paul-m paul-m changed the title 14708 refactored Service classes Refactor Service classes for better names Apr 30, 2023
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, quite disruptive/potentially breaking though. New point version.

@dafeder dafeder merged commit 66cd8e3 into 2.x May 3, 2023
@janette janette deleted the 14708-rename-service branch May 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants