Run functional tests with datastore_mysql_import enabled #3973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tests do not run with datastore_mysql_import module enabled, so there are no functional tests which support it.
This PR:
DatasetTest
functional test to a DrupalBrowserTestBase
test:DatasetBTBTest
DatasetBTBTest
toMySqlDatasetBTBTest
which enablesdatastore_mysql_import
and runs all the same tests.DatasetTest::testResourcePurgeDraft()
remains in the oldDatasetTest
class, because it depends onmoderated_content_bulk_publish
module, which has an incomplete config schema which failsBTB
testing.Since the new tests now use the real-deal services, and use some more strict validation from
BTB
, we discover that our tests (and modules) were buggy and needed some attention.DatasetBTBTest::getData()
we callValidMetadataFactory::get()
which validates the JSON. Our test JSON was not validating. See the @todo in that method.TODO in follow-ups:
DatasetTest::testResourcePurgeDraft()
to be aBTB
test.DatasetBTBTest::getData()
.